Luke Kanies schrieb:
> Here's the changelog so far:

Seems like I've managed to avoid all of these bugs in my manifests :) 

My puppetmaster now runs on c955f6130d0920ef18a0b01450ac873b31f73b9e and I'm running the same revision on my two test-hosts.

Things I noticed:

* warning: Puppet::Type.newtype(tidy) now expects a hash as the second argument, not Puppet::Type::File

Judging from the error message, this is probably a one-liner to fix.



* err: //Hosting_vserver_configuration[dasz]/hosting::full/dbp/Service[puppet]/enable: change from true to false failed: Execution of '/usr/sbin/update-rc.d puppet stop 1 2 3 4 5 6 .' returned 256: usage: update-rc.d [-n] [-f]  remove
       update-rc.d [-n]  defaults [NN | sNN kNN]
       update-rc.d [-n]  start|stop NN runlvl [runlvl] [...] .
                -n: not really
                -f: force


No idea how this slipped by me on the uptade to .2, but this is caused by a sloppy fix for #1060.

The fix is a oneliner, manually splitting the argument to update-rc.d and adding a default ordering number:

root@dasz:~/trunk# git diff
diff --git a/lib/puppet/provider/service/debian.rb b/lib/puppet/provider/service/debian.rb
index e54fb13..a2e19fa 100755
--- a/lib/puppet/provider/service/debian.rb
+++ b/lib/puppet/provider/service/debian.rb
@@ -14,7 +14,7 @@ Puppet::Type.type(:service).provide :debian, :parent => :init do
     # Remove the symlinks
     def disable
         update "-f", @resource[:name], "remove"
-        update @resource[:name], "stop 1 2 3 4 5 6 ."
+        update @resource[:name], "stop", "00", "1", "2", "3", "4", "5", "6", "."
     end

     def enabled?
root@dasz:~/trunk#


Regards, DavidS